[Bug]Fix bugs in imequalize, adjust_brightness and adjust_contrast #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #863 +/- ##
=======================================
Coverage 66.41% 66.42%
=======================================
Files 145 145
Lines 8770 8772 +2
Branches 1599 1599
=======================================
+ Hits 5825 5827 +2
Misses 2629 2629
Partials 316 316
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
MeowZheng
approved these changes
Mar 3, 2021
ZwwWayne
approved these changes
Mar 3, 2021
hellock
reviewed
Mar 3, 2021
| @@ -166,7 +166,7 @@ def _scale_channel(im, c): | |||
| s2 = _scale_channel(img, 1) | |||
| s3 = _scale_channel(img, 2) | |||
| equalized_img = np.stack([s1, s2, s3], axis=-1) | |||
| return equalized_img | |||
| return equalized_img.astype((img.dtype)) | |||
12 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In this pull request, bugs in
imequalize,adjust_brightnessandadjust_contrastare fixed and unittests are updated.For
imequalize,astpyeis missing, which will cause the output to be in wrong type(int64). #861For
adjust_brightnessandadjust_contrast, factor could be larger than 1. Clipping is needed since we use float32 to calculate.Pls kindly take a look. Thank you.